[pidcontroller] Implement previous state recovery on startup #13003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature allows the PID controller parameters to be updated and OpenHAB to be restarted without losing the current controller state. This is especially important for systems with a long response time. For example it might take up to a day for an underfloor heating controller to stabilise after losing state and having to build up the integrator value from zero. Signed-off-by: Lenno Nagel <lenno@nagel.ee>
lnagel
force-pushed
the
pidcontroller-state-recovery
branch
from
6eed376 to
466f5d2
Compare
fwolter
requested changes
Jun 26, 2022
|
|
||
| try { | ||
| value = getItemValueAsNumber(itemRegistry.getItem(itemName)); | ||
| logger.info("Item '{}' value {} recovered by PID controller", itemName, value); |
Signed-off-by: Lenno Nagel <lenno@nagel.ee>
Signed-off-by: Lenno Nagel <lenno@nagel.ee>
Signed-off-by: Lenno Nagel <lenno@nagel.ee>
|
Well I fixed everything, but it seems that builds are failing now (and I have a feeling that it's related to the build failures in main). |
jlaur
added
rebuild
fwolter
requested changes
Jul 2, 2022
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
|
Cheers! |
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…#13003) * [pidcontroller] Implement previous state recovery on startup This feature allows the PID controller parameters to be updated and OpenHAB to be restarted without losing the current controller state. This is especially important for systems with a long response time. For example it might take up to a day for an underfloor heating controller to stabilise after losing state and having to build up the integrator value from zero. Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Change logger.info -> logger.debug Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Change debug Item -> inspector Item in README Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Add documentation regarding state persistence Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Update bundles/org.openhab.automation.pidcontroller/README.md Signed-off-by: Fabian Wolter <github@fabian-wolter.de> * Update bundles/org.openhab.automation.pidcontroller/README.md Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…#13003) * [pidcontroller] Implement previous state recovery on startup This feature allows the PID controller parameters to be updated and OpenHAB to be restarted without losing the current controller state. This is especially important for systems with a long response time. For example it might take up to a day for an underfloor heating controller to stabilise after losing state and having to build up the integrator value from zero. Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Change logger.info -> logger.debug Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Change debug Item -> inspector Item in README Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Add documentation regarding state persistence Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Update bundles/org.openhab.automation.pidcontroller/README.md Signed-off-by: Fabian Wolter <github@fabian-wolter.de> * Update bundles/org.openhab.automation.pidcontroller/README.md Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…#13003) * [pidcontroller] Implement previous state recovery on startup This feature allows the PID controller parameters to be updated and OpenHAB to be restarted without losing the current controller state. This is especially important for systems with a long response time. For example it might take up to a day for an underfloor heating controller to stabilise after losing state and having to build up the integrator value from zero. Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Change logger.info -> logger.debug Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Change debug Item -> inspector Item in README Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Add documentation regarding state persistence Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Update bundles/org.openhab.automation.pidcontroller/README.md Signed-off-by: Fabian Wolter <github@fabian-wolter.de> * Update bundles/org.openhab.automation.pidcontroller/README.md Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…#13003) * [pidcontroller] Implement previous state recovery on startup This feature allows the PID controller parameters to be updated and OpenHAB to be restarted without losing the current controller state. This is especially important for systems with a long response time. For example it might take up to a day for an underfloor heating controller to stabilise after losing state and having to build up the integrator value from zero. Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Change logger.info -> logger.debug Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Change debug Item -> inspector Item in README Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Add documentation regarding state persistence Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Update bundles/org.openhab.automation.pidcontroller/README.md Signed-off-by: Fabian Wolter <github@fabian-wolter.de> * Update bundles/org.openhab.automation.pidcontroller/README.md Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…#13003) * [pidcontroller] Implement previous state recovery on startup This feature allows the PID controller parameters to be updated and OpenHAB to be restarted without losing the current controller state. This is especially important for systems with a long response time. For example it might take up to a day for an underfloor heating controller to stabilise after losing state and having to build up the integrator value from zero. Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Change logger.info -> logger.debug Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Change debug Item -> inspector Item in README Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Add documentation regarding state persistence Signed-off-by: Lenno Nagel <lenno@nagel.ee> * Update bundles/org.openhab.automation.pidcontroller/README.md Signed-off-by: Fabian Wolter <github@fabian-wolter.de> * Update bundles/org.openhab.automation.pidcontroller/README.md Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows the PID controller parameters to be updated and OpenHAB to be restarted without losing the current controller state.
This is especially important for systems with a long response time. For example it might take up to a day for an underfloor heating
controller to stabilise after losing state and having to build up the integrator value from zero.
In case the controller instance has configured OpenHAB items for the integral part, derivative part and error inspectors, then we can query the previous value from the persistance layer for these items and restore them during the controller startup.
I have been using this successfully for about 4 months now during the last heating season.